Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Flutter Web Example #1493

Merged
merged 7 commits into from
Aug 9, 2023
Merged

docs: update Flutter Web Example #1493

merged 7 commits into from
Aug 9, 2023

Conversation

sashatalalasha
Copy link
Contributor

Proposed changes

This PR installs new versions of dependencies, fixes Ory base URL used for Ory Proxy and updates the guide.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sashatalalasha sashatalalasha marked this pull request as draft August 4, 2023 13:21
@Benehiko
Copy link
Contributor

Benehiko commented Aug 4, 2023

Don't use the ory proxy for this please! I intentionally removed the proxy usage with the flutter example due to the test flakes. The proxy makes the flutter app significantly slower to load in the browser since it pushes all the flutter assets through the proxy! with the tunnel it's only serving Ory-related data and the flutter app is loaded directly from its own dev server.

Benehiko
Benehiko suggested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have commented on the PR - we shouldn't use the Ory Proxy with the flutter example!

code-examples/protect-page-login/flutter_web_redirect/env Outdated Show resolved Hide resolved
@sashatalalasha sashatalalasha marked this pull request as ready for review August 9, 2023 08:39
Benehiko
Benehiko approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Benehiko Benehiko merged commit a54d75b into ory:master Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benehiko Benehiko Benehiko approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashatalalasha @CLAassistant @Benehiko